[PATCH] Add session/list ACP method handler

[PATCH] Add session/list ACP method handler

[jgart]

Return a list of active session IDs.                                                                                                                                  

Thanks,                                                                                                                                                               

jgart

[PATCH] Add session/list ACP method handler.

[jgart]

Return a list of active session IDs.
---
 kaagum/tea.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/kaagum/tea.scm b/kaagum/tea.scm
index 6e750c0..822ba4a 100644
--- a/kaagum/tea.scm
+++ b/kaagum/tea.scm
@@ -438,6 +438,15 @@ in @code{tea-loop}."
                                                    ((name . command)
                                                     (command->spec name command)))
                                                  %commands))))))))))))
+             ("session/list"
+              ;; Return list of active session IDs.
+              (state-return
+               (list (acp-message `(("jsonrpc" . "2.0")
+                                    ("id" . ,request-id)
+                                    ("result"
+                                     ("sessions"
+                                      . ,(list->vector
+                                          (map car (focus state-sessions state))))))))))
              ("session/set_config_option"
               (let ((session-id (focus (in "params" "sessionId")
                                        request))
-- 
2.55.0

Re: [PATCH] Add session/list ACP method handler.

[Arun Isaac]

Hi jgart,

Thanks for the patch!

> +                                     ("sessions"
> +                                      . ,(list->vector
> +                                          (map car (focus
> state-sessions state))))))))))

Could you do this using match? In the interest of readability, we avoid
car, cdr and company.

And, looking at the ACP protocol spec
https://agentclientprotocol.com/protocol/v1/session-list#checking-support ,
we also need to advertise session listing under agentCapabilities. Could
you add that too?

Thanks!
Arun

Re: [PATCH] Add session/list ACP method handler.

[jgart]

I'll hold off on this patch until we spend more time determining what the next improvements to kaagum should be that are in line with the project's goals.

all the best,

jgart