public inbox for kaagum@systemreboot.net
 help / color / mirror / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: jgart <jgart@dismail.de>, kaagum@systemreboot.net
Subject: Re: [PATCH] Add session/list ACP method handler.
Date: Tue, 21 Jul 2026 00:38:31 +0100	[thread overview]
Message-ID: <874ihti64o.fsf@systemreboot.net> (raw)
In-Reply-To: <20260720143242.1203535-2-jgart@dismail.de>


Hi jgart,

Thanks for the patch!

> +                                     ("sessions"
> +                                      . ,(list->vector
> +                                          (map car (focus
> state-sessions state))))))))))

Could you do this using match? In the interest of readability, we avoid
car, cdr and company.

And, looking at the ACP protocol spec
https://agentclientprotocol.com/protocol/v1/session-list#checking-support ,
we also need to advertise session listing under agentCapabilities. Could
you add that too?

Thanks!
Arun

  reply	other threads:[~2026-07-20 23:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 14:31 jgart
2026-07-20 14:31 ` jgart
2026-07-20 23:38   ` Arun Isaac [this message]
2026-08-14 10:16     ` jgart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ihti64o.fsf@systemreboot.net \
    --to=arunisaac@systemreboot.net \
    --cc=jgart@dismail.de \
    --cc=kaagum@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox