From: Arun Isaac <arunisaac@systemreboot.net> To: Mathieu Othacehe <othacehe@gnu.org> Cc: guile-email@systemreboot.net Subject: Re: Fix tests with Guile 3.0.7 Date: Sat, 02 Oct 2021 01:28:43 +0530 [thread overview] Message-ID: <87lf3cjz4c.fsf@systemreboot.net> (raw) In-Reply-To: <87mtnv1r2p.fsf@gnu.org> [-- Attachment #1.1: Type: text/plain, Size: 258 bytes --] Hi Mathieu, Thanks for figuring this out! Instead of the unit length bytevector with an 'e' character, can we just use a unit length bytevector with the null character? That would be less surprising to the reader. WDYT? See attached patch. Regards, Arun [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1.2: 0001-email-Do-not-use-an-empty-bytevector-to-test-the-cha.patch --] [-- Type: text/x-patch, Size: 1077 bytes --] From 2f58690d2489a5bbacef77cf6a9143aae464e54a Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe <othacehe@gnu.org> Date: Wed, 29 Sep 2021 12:47:35 +0000 Subject: [PATCH] email: Do not use an empty bytevector to test the charset. Using an empty bytevector no longer throws an exception since Guile commit 5ea8c69e9153a970952bf6f0b32c4fad6a28e839. * email/email.scm (post-process-content-transfer-encoding): Use a bytevector of unit length to test the charset validity. Signed-off-by: Arun Isaac <arunisaac@systemreboot.net> --- email/email.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/email/email.scm b/email/email.scm index 3f4e194..fc1564e 100644 --- a/email/email.scm +++ b/email/email.scm @@ -832,7 +832,7 @@ values. The returned headers is a string and body is a bytevector." (define (valid-charset? charset) (catch #t (lambda () - (bytevector->string (make-bytevector 0 0) charset) + (bytevector->string (make-bytevector 1 0) charset) #t) (const #f))) -- 2.33.0 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 524 bytes --]
next prev parent reply other threads:[~2021-10-01 19:58 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-29 12:53 Mathieu Othacehe 2021-10-01 19:58 ` Arun Isaac [this message] 2021-10-06 8:58 ` Arun Isaac
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87lf3cjz4c.fsf@systemreboot.net \ --to=arunisaac@systemreboot.net \ --cc=guile-email@systemreboot.net \ --cc=othacehe@gnu.org \ --subject='Re: Fix tests with Guile 3.0.7' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox