guile-email discussion
 help / color / mirror / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 49115-done@debbugs.gnu.org, guile-email@systemreboot.net
Subject: Re: Mumi inserts spurious underscore in bug title
Date: Sun, 01 Jan 2023 13:15:02 +0100	[thread overview]
Message-ID: <87ilhq5lyw.fsf@elephly.net> (raw)
In-Reply-To: <87ilhungt4.fsf@systemreboot.net>


Hi Arun,

> Thanks for the bug report!
>
> It's very strange, but I'm not able to reproduce this.

Thank you for your analysis!

> Even at https://issues.guix.gnu.org/49114 , only the "bug title" has the
> spurious underscore. The subject of the first message does not. Is the
> bug title something stored in the xapian index? Could it be that this
> was an older bug that has corrupted the xapian index?

As part of #60410 I rebuilt the xapian database (deleted it and then ran
“mumi fetch”), so it’s not that.

[… time passes …]

I think I found the culprit in mumi/debbugs.scm:

    (define qp-pattern "=\\?UTF-8\\?Q\\?([^?]+)\\?=")
    …
    (let ((subject (or (assoc-ref properties "Subject") "")))
      (if (string-contains subject "=?UTF-8?Q?")
          (or (false-if-exception
               (utf8->string
                (quoted-printable-decode
                 (regexp-substitute/global #f qp-pattern
                                           subject 'pre 1 'post))))
              subject)
          subject))

I’m probably not using quoted-printable-decode correctly.  My apologies
for assuming a bug in Guile Email.  I changed this with commit
9d7eb3c5efe6427a1a89fb3e4c7165259edff4dd, using parse-email-headers.

> If I understand correctly, mumi does not rebuild its xapian index. I
> think it should do so from time to time. It would help prevent old bugs
> from getting persisted in storage.

True.  I’ll be sure to rebuild the index on the next upgrade.

> Cheers, and wish you a Happy New Year! :-)

Thank you, and a Happy New Year to you too!

-- 
Ricardo


  reply	other threads:[~2023-01-01 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-24 22:53 Ricardo Wurmus
2022-12-29 19:36 ` Arun Isaac
2023-01-01 12:15   ` Ricardo Wurmus [this message]
2023-01-02 17:43     ` [PATCH 0/1] Do not check for MIME encoded words Arun Isaac
2023-01-02 17:43     ` [PATCH 1/1] debbugs: Do not check for MIME encoded words in subject Arun Isaac
2023-01-02 19:34       ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilhq5lyw.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=49115-done@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=guile-email@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox