guile-email discussion
 help / color / mirror / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: guile-email@systemreboot.net
Subject: Re: [guile-email] decoding-error crash
Date: Mon, 23 Sep 2019 08:30:31 +0100	[thread overview]
Message-ID: <875zljwju0.fsf@cbaines.net> (raw)
In-Reply-To: <cu74l13egg3.fsf@systemreboot.net>

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]


Arun Isaac <arunisaac@systemreboot.net> writes:

>> I think there might be other emails on the guix-commits mailing list
>> that still can't be read.
>>
>> For testing, I downloaded
>> https://lists.gnu.org/archive/mbox/guix-commits/2019-08 and then tried
>> to read it with:
>>
>>   (map parse-email (call-with-input-file "2019-08" mbox->emails))
>
> These errors occur due to the occurrence of non-standard ISO-8859-1
> characters in the headers due to Emacs message mode parens style
> addresses. The earlier fix only allows UTF-8 or ASCII characters. I have
> pushed a new fix that uses the substitute conversion strategy to
> silently fail without an error in the event of something other than
> UTF-8 or ASCII encoding.
>
> https://git.systemreboot.net/guile-email/commit/?id=c10524726e0a91445a0329cc9aa72b7467258381
>
> The alternative to this is to implement some complicated encoding
> guessing scheme. I'm not sure it's worth the effort. WDYT?

Awesome, thanks Arun. Substituting invalid characters works for me.

Would you be up for doing a release with these changes at some point?
Then the 'patch-module-dir phase could be removed from the Guix package
definition as well.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  parent reply	other threads:[~2019-09-23  8:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-15 12:57 Christopher Baines
2019-09-16  9:50 ` Arun Isaac
2019-09-16  9:50   ` Arun Isaac
2019-09-16 16:32   ` Arun Isaac
2019-09-16 16:32     ` Arun Isaac
2019-09-16 20:20     ` Arun Isaac
2019-09-16 20:20       ` Arun Isaac
2019-09-22 13:19       ` Christopher Baines
2019-09-23  5:21         ` Arun Isaac
2019-09-23  5:21           ` Arun Isaac
2019-09-23  7:30           ` Christopher Baines [this message]
2019-09-23 19:28             ` Arun Isaac
2019-09-23 19:28               ` Arun Isaac
2019-09-24  7:17               ` Christopher Baines
2019-09-16 20:55     ` Christopher Baines
2019-09-17  5:37       ` Arun Isaac
2019-09-17  5:37         ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zljwju0.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=arunisaac@systemreboot.net \
    --cc=guile-email@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox